Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heading shifted problem fixed #135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kisharnath
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for lichterio ready!

Name Link
🔨 Latest commit 4033abd
🔍 Latest deploy log https://app.netlify.com/sites/lichterio/deploys/66556ca4a3305a00082af0d0
😎 Deploy Preview https://deploy-preview-135--lichterio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image ^^^ Before

vvvv With the change
image

Removing the class will break the layout

@kisharnath
Copy link
Contributor Author

I have updated the code
I noticed another bug that this same thing happens on 1024px width. I have also fixed that
here is the screeshot
Screenshot 2024-04-14 164232

pages/index.vue Outdated Show resolved Hide resolved
<div class="flex gap-8 -mx-4 md:mx-0">
<div class="flex w-1/2 md:w-full items-center">
<AppParagraph tag="h1" look="superHeading"
class="flex flex-col sm:justify-start font-mono mt-8 md:mt-0 ml-4 md:ml-0">
class="flex flex-col sm:justify-start font-mono mt-8 md:mt-0 ml-4 md:ml-0 md:text-[55.1px] lg:text-[83px]">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use rem's instead of pixels here? Ideally via predefined classes like text-xl? 🤔

@kisharnath
Copy link
Contributor Author

ok I will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants